How Crashplan breaks xpcshell tests on Windows

Posted: November 23rd, 2011

I recently switched to a Windows laptop and have been going through the usual teething pains related. One thing that confused me though was that when I was running xpcshell tests on my new machine they would frequently fail with access denied errors. I’ve seen this sort of thing before so I know some service was monitoring files and opening them after they had changed, when this happens they can’t be deleted or edited until the service closes them again and often tests open, close and delete files so fast that there isn’t time for that to happen.

It took me a little while to remember that I can just use Process Monitor to track down the offending service. Just fire it up, set a filter to only include results to a particular directory (the temp directory in this case) and go create a file there and see what shows up. I was quite surprised to see Crashplan, the backup software I (and probably many people in Mozilla) use. Surprised because Crashplan isn’t set to backup my temp directory and really I shudder to think what the performance cost is of something continually accessing every file that changes in the temp directory.

Turns out you can turn it off though. Hidden in the depths of Crashplan’s advanced backup settings is an option to disable real-time filesystem watching. From what I can see online the downside to this is that files will only be backed up once a day, but that’s a pretty fine tradeoff to  having functioning xpcshell tests for me. There is also an option to put crashplan to sleep for an hour or so, that seems to work too but I don’t know exactly what that does.

It confuses me a little why Crashplan monitors files it never intends to backup (even when the backup server isn’t connected and backups aren’t in progress) and it is quite a lot of file accesses it does too. Seems likely to be a bug to me but at least I can workaround it for now.

Tags: , , ,

1 Comment »

Categories: general, mozilla

Overlays without overlays in restartless add-ons

Posted: October 31st, 2011

Perhaps the most common way of making changes to Firefox with an extension has always been using the overlay. For a window’s UI you can make changes to the underlying XUL document, add script elements to be executed in the context of the normal window’s code and add new stylesheets to the window to change how the UI looks.

Restartless add-ons change this around completely, the normal overlay and style-overlay mechanisms just aren’t available to restartless add-ons and this is likely to remain true for a while, these methods don’t clean up after themselves when the add-on is uninstalled.

This can make things hard, particularly for porting older add-ons to become restartless. I was in this situation earlier this weekend. I was working on porting David Ascher‘s WebTabs for Thunderbird to be restartless. I could have just moved all the script code over to bootstrap.js but in many ways it is nice to keep the code that works on the main UI separate to the code that runs for the preferences UI etc. Plus I like to play around with new ways of doing things so I developed a JS module I’m calling the OverlayManager.

The OverlayManager watches for new windows being opened and for every new window it can run JS script and apply CSS stylesheets to the window in a way that is easy to undo if the add-on is disabled at runtime. Although it can’t do any XUL modifications right now (I didn’t need any for this particular extension) it would be pretty easy to extend this to support a minimum about of XUL overlays.

Stylesheets are loaded by adding a HTML style tag to the XUL document, so they can be removed easily when the add-on is disabled. Scripts are handled in a way that may even be better than normal overlays. In the old system extension scripts all run in the same context as the window they overlay giving rise to the possibility of conflicts. Restartless add-ons shouldn’t do this since it makes removing the script code again much more troublesome. The OverlayManager handles it by creating a sandbox to run the script in. The sandbox’s prototype is set to the window the script is being run for meaning the script sees all the functions and objects of the window directly in its own scope but as long as it doesn’t modify any of the objects in the main window’s code all we have to do is throw away the sandbox to get rid of its JS.

There are a few things different of course. The script shouldn’t use load and unload event handlers for the window as it may get loaded well after the window does or unloaded well before. Instead the OverlayManager looks for an OverlayListener object in the script and calls load and unload methods on it, these are called either with the window’s real load and unload events or while the window is open normally. You also can’t reference code in the script from JS string blocks, so if you set onclick="myfunc()" on a XUL element it wouldn’t work because that would run in the main window scope which can’t see the sandbox code at that point. This tends to be pretty simple to get around by using addEventListener for all your events though.

You can see the existing state of the code on github and an example of the structure you’d pass to OverlayManager.addOverlays is in the bootstrap script for the same project. It is appropriately licensed so go nuts!

Update: I changed the stylesheets to use XML processing instructions to be more like they work currently and just for fun I implemented the very basics of document overlaying, almost totally untested though so YMMV.

Tags: , , ,

7 Comments »

Categories: mozilla

Mossop Status Update: 2011-10-29

Posted: October 29th, 2011

Done:

  • Implemented a number of performance fixes for mobile (bug 696141 and dependents)
  • Reviewed more of the default to compatible work
  • Basic implementation for add-on hotfix (bug 694068)
  • Landed the final third-party add-on patches on aurora and beta
  • Product planning meeting for Firefoxes 8, 9 and 10

Next:

  • Finish the add-on hotfix work
  • Various HR stuff
  • Start planning Jetpack work week

Tags: , ,

Comments Off

Categories: mozilla

Mossop Status Update: 2011-10-14

Posted: October 14th, 2011

Done:

  • 7.0.1 Post Mortem
  • Hotfix planning work
  • Understanding the new mobile architecture
  • Problems with third party add-ons in Firefox 8
  • Default to compatible planning
  • Final draft of Q4 goals

Next:

  • Update module description for the Jetpack module
  • Fix third-party add-on detection problems

Tags: , ,

Comments Off

Categories: mozilla

Mossop Status Update: 2011-10-07

Posted: October 7th, 2011

Done:

  • Worked with the team to fix the version number problems with the last repacks
  • Security reviews for embedded add-on preferences and showing performance information to users
  • Working on Q4 goals for the team

Next:

  • Finalize Q4 goals
  • Update module description for the Jetpack module

Tags: , ,

Comments Off

Categories: mozilla

Mossop Status Update: 2011-09-02

Posted: September 2nd, 2011

Done:

  • Worked with the Jetpack drivers to come up with a new way to prioritise bugs
  • Talked over issues with add-on compatibility and version upgrades
  • Helped prepare a test plan for SDK repacks
  • Killed most of my review queue

Next:

  • Try to clear anything that is blocked on me before my vacation

Tags: , ,

1 Comment »

Categories: mozilla

Mossop Status Update: 2011-08-26

Posted: August 26th, 2011

Done:

  • Regular bug triage (epic bug triage deferred)
  • Tinkering with the Bugzilla APIs
  • Cleared out my inbox and review queues

Next:

  • Formalise priorities for the Jetpack team

Next week I'll probably be in and out randomly as relatives and friends are going to be in town

Tags: , ,

Comments Off

Categories: mozilla

Mossop Status Update: 2011-08-15

Posted: August 15th, 2011

Done:

  • Landed UI to allow users to check they have the add-ons they want on next upgrade (bug 596343)
  • Landed UI to allow users to confirm that they want third-party add-ons before they are enabled (bug 476430)
  • E10S planning

Next:

  • Fix test failures on aurora
  • Mobile planning

Tags: , ,

Comments Off

Categories: mozilla

Adding add-on preferences to the Add-ons Manager

Posted: July 7th, 2011

For some time now Firefox for mobile has had this nice feature where add-ons could embed their preferences right into the list of add-ons, no need to open a whole a new window like add-ons for desktop have to. During the development of Firefox 4 we were a little jealous of what the mobile team had done and so we drew up some ideas for how the same functionality would look on desktop. We didn’t get time to implement them then but I’m excited that someone from the community stepped up and implemented it for us. Not just that but he made the code shared between mobile and desktop, added some new option types and made it work fine for restartless add-ons which are unable to register their own chrome.

The basic idea is simple. Create a XUL file containing a list of <setting> elements. Different types of settings are possible, checkboxes, input boxes, menulists, buttons, etc. Each one shows up as a row in the details view for an add-on in the add-ons manager. The XUL file can either be just added to your XPI (call it options.xul) or referenced by the optionsURL option in your install.rdf.

Get it right and you’ll see something like this:

I want to thank Geoff Lankow (darktrojan on IRC) for his awesome work getting this done. This feature is now in the Aurora builds and it’d be great to get add-on developers playing with it. Geoff even wrote up some detailed docs to help you out.

As a bonus Geoff also implemented support for in-tab preferences. This makes Firefox load an add-ons options UI in a new tab instead of a new window. Setting the optionsType property to 3 enables this.

Tags: , , , ,

13 Comments »

Categories: mozilla

Unloading JS modules

Posted: July 7th, 2011

One of the problems with writing a restartless add-on is that you have to be careful about undoing anything your add-on does when it is told to shutdown. This means that right now some features of the platform can’t be used as we have no way to undo them. Recently I made this list a little shorter by making it possible to unload JS modules loaded with Components.utils.import().

Just call Components.utils.unload(uri) and the module loaded from that URI will be unloaded. Take care when you do this because something might still have references into it which will stop working. Firefox also caches the module’s code for fast loading the next time around. The add-ons manager clears this cache when your add-on is updated or uninstalled so you mostly don’t have to worry about it but if you do something strange like unload a module, manually alter the file and then import it again you won’t get the latest code.

This support is in the upcoming Aurora build.

Tags: , ,

Comments Off

Categories: mozilla